Tsify main #4520

jeremy-rifkin · 2022-12-30T18:32:58Z

(Also fixes #4521)

jeremy-rifkin · 2022-12-30T18:33:22Z

lib/common-utils.ts

@@ -0,0 +1,34 @@
+// Copyright (c) 2022, Compiler Explorer Authors


File is from #4490

jeremy-rifkin · 2022-12-30T18:34:36Z

static/panes/editor.ts

@@ -195,7 +195,6 @@ export class Editor extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Edit
    override createEditor(editorRoot: HTMLElement): editor.IStandaloneCodeEditor {
        const editor = monaco.editor.create(
            editorRoot,
-            // @ts-expect-error: options.readOnly and anything inside window.compilerExplorerOptions is unknown


Got an error TS2578: Unused '@ts-expect-error' directive here, I went ahead and added readOnly to options.interfaces.ts while I was here

static/main.ts

jeremy-rifkin · 2022-12-31T06:35:48Z

static/main.ts

+
+const siteTemplateScreenshots = require.context('../views/resources/template_screenshots', false, /\.png$/);
+
+if (!window.PRODUCTION && !options.embedded) {


Fixes #4521, cc @RubenRBS It looks like global.sinon isn't defined for embedded in static/tests/motd

Ohh, good catch

RubenRBS

Also love this one :)
You'll need to deal with the duplicated file in both types PRs, but nothing too hard specially as both PRs are yours

RubenRBS · 2023-01-10T20:27:27Z

static/main.ts

@@ -22,42 +22,52 @@
 // ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 // POSSIBILITY OF SUCH DAMAGE.

-'use strict';


Looks like there were no type errors in the js version judging by the diff, which is pretty unexpected seeing how the rest of the TS conversions have gone down, so I'm pleasantly supprised :)

RubenRBS · 2023-01-10T20:29:16Z

static/main.ts

-function fixBugsInConfig(config) {
-    if (config.activeItemIndex && config.activeItemIndex >= config.content.length) {
-        config.activeItemIndex = config.content.length - 1;
+// TODO(jeremy-rifkin): Unsure of the type, just typing enough for `content` at the moment


I'm suprised that this is not just a config from GoldenLayout 🤔 That's weird

I think it is the golden layout config yes...which we're trying to fix up to account for a short lived bug from the early 17th Century where the item index count be longer than the content.

That said: I can't see any evidence for that in the git history: @partouf appears to have added this in 5e5e601 and it doesn't look like it was there before (or my git-fu is weak, which is very possible)

Oh I see, I just tried typing as GoldenLayout.Config but apparently config.activeItemIndex doesn't exist

RubenRBS · 2023-01-10T20:29:49Z

static/main.ts

-            .object()
-            .value();
+        const filters = Object.fromEntries(((params.filters as string) || '').split(',').map(o => [o, true]));
+        // TODO(jeremy-rifkin): Fix types


What do you think is the easiest way to do this in this case?

I don't remember why I put this comment here :P I think it was just about the various casts. The string cast should be resolved once we type params and then I think a small modification of the ParseFiltersAndOutputOptions type will "just work"

mattgodbolt

LGTM: one superminor only, feel free to merge (but let me know when you do!) I'd like to do a "zomg typescript" push this month and this is a key part :)

mattgodbolt · 2023-01-11T02:38:36Z

static/settings.ts

@@ -42,7 +44,7 @@ export interface SiteSettings {
    colourScheme: ColourScheme;
    compileOnChange: boolean;
    // TODO(supergrecko): make this more precise


is this TODO done now?

Yes I think so!

mattgodbolt · 2023-01-11T02:45:16Z

static/main.ts

-function fixBugsInConfig(config) {
-    if (config.activeItemIndex && config.activeItemIndex >= config.content.length) {
-        config.activeItemIndex = config.content.length - 1;
+// TODO(jeremy-rifkin): Unsure of the type, just typing enough for `content` at the moment


I think it is the golden layout config yes...which we're trying to fix up to account for a short lived bug from the early 17th Century where the item index count be longer than the content.

That said: I can't see any evidence for that in the git history: @partouf appears to have added this in 5e5e601 and it doesn't look like it was there before (or my git-fu is weak, which is very possible)

jeremy-rifkin · 2023-01-14T00:35:22Z

static/panes/editor.ts

@@ -867,7 +867,7 @@ export class Editor extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Edit

    changeLanguage(newLang: string): void {
        if (newLang === 'cmake') {
-            this.selectize.addOption(languages.cmake);
+            this.selectize.addOption(unwrap(languages.cmake));


Merging with main introduced a type error here so I needed to unwrap

jeremy-rifkin added 2 commits December 28, 2022 18:32

Initial conversion work

2649925

Type work

bdd988b

github-actions bot added the ui label Dec 30, 2022

jeremy-rifkin commented Dec 30, 2022

View reviewed changes

jeremy-rifkin added 3 commits December 30, 2022 11:46

Fix bug in fixBugsInConfig

bcc1766

Merge branch 'main' into jr/tsify-main

2cfea04

Type work

ea666b9

jeremy-rifkin commented Dec 31, 2022

View reviewed changes

jeremy-rifkin marked this pull request as ready for review December 31, 2022 06:35

RubenRBS approved these changes Jan 10, 2023

View reviewed changes

mattgodbolt approved these changes Jan 11, 2023

View reviewed changes

jeremy-rifkin added 2 commits January 12, 2023 10:53

Resolved TODO

58e7ecc

Merge branch 'main' into jr/tsify-main

c191d26

jeremy-rifkin commented Jan 14, 2023

View reviewed changes

Fix eslint errors / warnings

1bad99d

github-actions bot added the lang-hook label Jan 14, 2023

jeremy-rifkin merged commit 33167a3 into main Jan 14, 2023

jeremy-rifkin deleted the jr/tsify-main branch January 14, 2023 00:52

mattgodbolt pushed a commit that referenced this pull request Jan 24, 2023

Tsify main (#4520)

55cc275

jeremy-rifkin mentioned this pull request Jan 25, 2023

Frontend TypeScript conversion tracking thread #2981

Closed

32 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tsify main #4520

Tsify main #4520

jeremy-rifkin commented Dec 30, 2022 •

edited

jeremy-rifkin Dec 30, 2022

jeremy-rifkin Dec 30, 2022 •

edited

jeremy-rifkin Dec 31, 2022

RubenRBS Dec 31, 2022

RubenRBS left a comment

RubenRBS Jan 10, 2023

RubenRBS Jan 10, 2023

mattgodbolt Jan 11, 2023

jeremy-rifkin Jan 12, 2023

RubenRBS Jan 10, 2023

jeremy-rifkin Jan 12, 2023

mattgodbolt left a comment

mattgodbolt Jan 11, 2023

jeremy-rifkin Jan 12, 2023

mattgodbolt Jan 11, 2023

jeremy-rifkin Jan 14, 2023 •

edited

		@@ -0,0 +1,34 @@
		// Copyright (c) 2022, Compiler Explorer Authors


		const siteTemplateScreenshots = require.context('../views/resources/template_screenshots', false, /\.png$/);

		if (!window.PRODUCTION && !options.embedded) {

Tsify main #4520

Tsify main #4520

Conversation

jeremy-rifkin commented Dec 30, 2022 • edited

Choose a reason for hiding this comment

jeremy-rifkin Dec 30, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RubenRBS left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattgodbolt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeremy-rifkin Jan 14, 2023 • edited

Choose a reason for hiding this comment

jeremy-rifkin commented Dec 30, 2022 •

edited

jeremy-rifkin Dec 30, 2022 •

edited

jeremy-rifkin Jan 14, 2023 •

edited