fix: empty exclude value in option file badly handled #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An empty value for exclude prop for tool ends up being interpreted as a * wildcard. The variable is a string[] and is set to a single empty string. fixes #4544 Signed-off-by: Marc Poulhiès <dkm@kataplop.net>
|
I'm not sure if this is correct, but if an empty exclude list just leaves the tool out for everyone, then one might have better chosen to just remove the tool altogether |
My initial fix was to remove the empty exclude, but then saw the doc gave the template with empty exclude, so figured the empty exclude is to be interpreted as "nothing to exclude" and not "exclude everything because everything can be searched with an empty string"... |
mattgodbolt
pushed a commit
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty value for exclude prop for tool ends up being interpreted as a * wildcard. The variable is a string[] and is set to a single empty string.
fixes #4544
Signed-off-by: Marc Poulhiès dkm@kataplop.net