Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new Xtensa Esp32 compilers. #4575

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

euripedesrocha
Copy link
Contributor

Adding new compilers to the configuration. This depends on compiler-explorer/infra#926

Copy link
Member

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are missing from the list of compilers (so wouldn't get picked up). I'll merge and add them in so we can get this live. Sorry for the delay.

@mattgodbolt mattgodbolt merged commit a497dce into compiler-explorer:main Jan 24, 2023
mattgodbolt added a commit that referenced this pull request Jan 24, 2023
@euripedesrocha
Copy link
Contributor Author

Hi @mattgodbolt, from your comment I understand that there is one step missing to get this live. I looked into the original PR(that added the compilers) and docs and couldn't figure it out what is missing. I can open another PR with the missing configuration, but would need some help.

@dkm
Copy link
Member

dkm commented Jan 24, 2023

I don't think you can do anything else. When changes are merged in the main branch, it means that they will be live with our next release. We usually do new releases once every few days, so that should be a short wait now.

@mattgodbolt
Copy link
Member

@euripedesrocha - I made the change in the above commit: all's well! Don't worry. These should be live now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants