Setup TS testing infrastructure #4659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 tasks
mattgodbolt
approved these changes
Jan 29, 2023
package.json
Outdated
| @@ -103,6 +103,7 @@ | |||
| "@types/express": "^4.17.14", | |||
| "@types/fs-extra": "^9.0.13", | |||
| "@types/jquery": "^3.5.10", | |||
| "@types/mocha": "^10.0.1", | |||
There was a problem hiding this comment.
that's a way newer version than the mocha we're using, but I guess it works ok anyway: our mocha is stuck in the past because of the ESM issue.
There was a problem hiding this comment.
Yeah, @types/xyz versions don't always correspond to xyz's repositories so I wasn't sure what to do. At least for the file I converted the types seemed fine. I can try throwing a 8.x.x version on and see.
junlarsen
approved these changes
Jan 29, 2023
|
Thanks @matsjla, I haven't tried out |
|
Okay sounds great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and tsify test/ansi-to-html-tests at the same time)