Tsify asm-docs-tests to typescript with utils #4670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 tasks
|
|
||
| import {CompilationEnvironment} from '../lib/compilation-env'; | ||
| import {CompilationQueue} from '../lib/compilation-queue'; | ||
| import {CompilerProps, fakeProps} from '../lib/properties'; | ||
|
|
||
| export function makeCompilationEnvironment(options) { | ||
| // TODO: Find proper type for options | ||
| export function makeCompilationEnvironment(options: Record<string, any>): CompilationEnvironment { |
There was a problem hiding this comment.
This might be https://github.com/compiler-explorer/compiler-explorer/blob/main/lib/options-handler.ts#L58 but we can clean up the types here in a future PR
There was a problem hiding this comment.
Doesn't seem like it since we're asking .props, .concurrency, and .queue, all of which don't really make sense on the ce options
jeremy-rifkin
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the final few bits needed in tsconfig to properly run the chai-http test infrastructure as well as turning the asm docs tests into ts