Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cache handling on the frontend, cache executions on the backend, and improve controls on the exec pane #5111

Merged
merged 15 commits into from
Jun 11, 2023

Conversation

jeremy-rifkin
Copy link
Member

No description provided.

@github-actions github-actions bot added the ui label Jun 6, 2023
@jeremy-rifkin jeremy-rifkin marked this pull request as ready for review June 6, 2023 03:50
@jeremy-rifkin
Copy link
Member Author

Should be good. I'll test thoroughly tomorrow and fix test cases / merge conflicts and whatnot.

@jeremy-rifkin
Copy link
Member Author

jeremy-rifkin commented Jun 6, 2023

This should close #3030 (will test tomorrow to double check)

lib/base-compiler.ts Outdated Show resolved Hide resolved
@jeremy-rifkin
Copy link
Member Author

Alright, tested locally and everything is behaving how I want it. Does in fact close 3030.

@jeremy-rifkin
Copy link
Member Author

The interface change in this PR gets rid of the circle arrow button in the top-right corner and adds a re-run button next to the clear cache and recompile button
image

Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

lib/handlers/compile.ts Show resolved Hide resolved
docs/API.md Show resolved Hide resolved
views/templates/panes/executor.pug Show resolved Hide resolved
@jeremy-rifkin jeremy-rifkin merged commit 60ce06b into main Jun 11, 2023
13 checks passed
@jeremy-rifkin jeremy-rifkin deleted the jr/cache-exec-work branch June 11, 2023 23:10
jeremy-rifkin added a commit that referenced this pull request Jun 12, 2023
@partouf
Copy link
Contributor

partouf commented Jun 14, 2023

this is now live

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants