Capture errors in sentry better #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-rifkin
changed the title
RubenRBS
approved these changes
Jun 10, 2023
|
this is now live |
mattgodbolt
pushed a commit
that referenced
this pull request
Jul 22, 2023
Fixes #5127 and similar issues. Rationale: Whenever something that is not an Error object is passed to Sentry.captureException we get pretty much no useful information in sentry  (usually not even a stacktrace)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5127 and similar issues.
Rationale: Whenever something that is not an Error object is passed to Sentry.captureException we get pretty much no useful information in sentry
(usually not even a stacktrace)