Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CFG viewer navigation and behavior #5134

Merged
merged 3 commits into from
Jun 11, 2023
Merged

Improve CFG viewer navigation and behavior #5134

merged 3 commits into from
Jun 11, 2023

Conversation

jeremy-rifkin
Copy link
Member

No description provided.

@github-actions github-actions bot added the ui label Jun 11, 2023
@RubenRBS
Copy link
Member

My gripe abous this is if we want zoom to be a persisted state. I'm also leaning towards yes, but I had some doubts about whether it makes sense/works for different DPI monitors/scales/resolutions. Is it consistent among those?

@jeremy-rifkin
Copy link
Member Author

I was thinking about the same issues regarding making zoom (and panning) part of the state. For this PR I left zoom/pan out of the state because of concerns with other people's monitors and instead added some logic to zoom in on the function's entry block the first time the pane is loaded.

@jeremy-rifkin jeremy-rifkin changed the title Add zooming / focusing and persistent state to the CFG viewer Improve CFG viewer navigation and behavior Jun 11, 2023
@jeremy-rifkin jeremy-rifkin merged commit 8d624b5 into main Jun 11, 2023
13 checks passed
@jeremy-rifkin jeremy-rifkin deleted the jr/fix/cfg-states branch June 11, 2023 23:12
@partouf
Copy link
Contributor

partouf commented Jun 14, 2023

this is now live

@partouf
Copy link
Contributor

partouf commented Jun 14, 2023

(The fonts are different in the image exports, was that normal?)

@jeremy-rifkin
Copy link
Member Author

Hmm, I can't seem to reproduce. It looks ok on my machine. What browser are you using?

@jeremy-rifkin jeremy-rifkin added this to Completed in CFG enhancements Jun 14, 2023
@partouf
Copy link
Contributor

partouf commented Jun 15, 2023

Hmm, I can't seem to reproduce. It looks ok on my machine. What browser are you using?

An old version I think Google Chrome Version 112.0.5615.165 (Official Build) (64-bit) on UB20

cfg (1)

mattgodbolt pushed a commit that referenced this pull request Jul 22, 2023
@jeremy-rifkin @mattgodbolt
Improve CFG viewer navigation and behavior (#5134)
2db37fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ui
Projects
CFG enhancements
Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeremy-rifkin @RubenRBS @partouf