Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No 'forbidden switches' #5736

Merged

Conversation

OfekShilon
Copy link
Member

@OfekShilon OfekShilon commented Nov 11, 2023

~0.5Y ago I tried to raise a local CE instance to experiment with an in-house clang plugin. This eventually succeeded but only after much grief and an advice from partouf.

The conjecture raised at that Discord thread was that the optionsForbiddenRe property was devised circa 2015 to block plugin usage (and others) as these were considered an attack surface. If that is the case - this is no longer true since using nsjail.

@OfekShilon OfekShilon changed the title Empty forbidden switches No 'forbidden switches' Nov 11, 2023
Copy link
Member

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattgodbolt mattgodbolt merged commit 3ca11cd into compiler-explorer:main Nov 12, 2023
8 checks passed
@OfekShilon OfekShilon deleted the Empty_forbidden_switches branch November 12, 2023 20:25
@mattgodbolt
Copy link
Member

This is now live

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants