Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New snowball syntax #5738

Merged
merged 9 commits into from Nov 14, 2023
Merged

New snowball syntax #5738

merged 9 commits into from Nov 14, 2023

Conversation

mauro-balades
Copy link
Contributor

No description provided.

@mauro-balades
Copy link
Contributor Author

idk why it includes other commits

@mauro-balades
Copy link
Contributor Author

Don't merge yet, please

@jeremy-rifkin
Copy link
Member

Hi @mauro-balades, I'll convert your PR to a draft so we don't merge it. Mark it ready for review when it's good to go.

@jeremy-rifkin jeremy-rifkin marked this pull request as draft November 12, 2023 22:10
@mauro-balades mauro-balades marked this pull request as ready for review November 12, 2023 22:12
@mauro-balades
Copy link
Contributor Author

alr, fixed. 😌

@mauro-balades
Copy link
Contributor Author

100% fixed now

@mattgodbolt
Copy link
Member

Is this ready" You seem to have mostly added comments to your examples. Is the one-line fix that changes the base syntax the actual "new snowball syntax" ? Just trying to understand from the context of the PR, as you earlier said it included other commits

@mauro-balades
Copy link
Contributor Author

Yeah, I don't know why it's past commits, GitHub is messing with me. I updated/fixed syntax highlighting and the examples. Since ddea1d1 basically

@mauro-balades
Copy link
Contributor Author

If it's a problem, I can delete the repo and re-write the commits. Idk why GitHub just doesn't allow me to rebase

@mattgodbolt
Copy link
Member

I'm cool with whatever, it'll get rebased as we merge here. I just wanted to make sure we had the right changes.

@mattgodbolt mattgodbolt merged commit 058dc15 into compiler-explorer:main Nov 14, 2023
8 checks passed
@mauro-balades
Copy link
Contributor Author

Thanks! I think it looks much better with this syntax highlighting.

@mauro-balades mauro-balades deleted the new-snowball-syntax branch November 14, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgodbolt mattgodbolt mattgodbolt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mauro-balades @jeremy-rifkin @mattgodbolt