-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update llvm-objdump for Webassembly #6589
Update llvm-objdump for Webassembly #6589
Conversation
The previous version seems to not be working on the live enviornment.
Apologies I merged and did not test your change last night! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're probasblby right here! thank you
this is rolling out now. seems to work better; the "execute" the app doesn't work for reasons I can't dig in to right now, but compiling to binary worked |
Neat! I haven't really tested the "Execute the code" functionality if that's what you're referring to. But I wouldn't be surprised if it doesn't work, the binary that wasmtime builds is an ELF file, but that's just a detail, it's not supposed to be a standalone executable, it has to be invoked with wasmtime. I'll try to figure out how to work that in at some point. |
Unfortunately this seems to have not fixed the issue on the live site 😞 . @mattgodbolt Is there any way I can debug these failures? I can't reproduce them locally. |
Super odd; I don't know why this isn't working, I swear it worked when I tested it before! |
From our logs it's like we haven't deployed this version somehow, I see:
which looks like it's still executing just raw |
Oh shucks: I think I deployed the wrong version |
deploying now for real...will be ~30m |
Nice, thanks for looking into this! ❤️ (Edit: Seems to work now! 🎉 ) |
👋 Hey, The Webassembly language was recently added (in compiler-explorer#6429). I tested it today on the live enviornment, and it appears to not be working (example: https://godbolt.org/z/YP5KdscEM). I don't really know how to debug this, there is no other output other than `objdump returned 255` which doesn't tell me a whole lot. (If someone can help me investigate this it would be appreciated) Looking at the configs for the other languages, they always specify a objdump binary in the `/opt` path, so maybe `llvm-objdump` is not available in the system? This PR attempts to fix it by changing to a fixed version of `llvm-objdump` in the `/opt` install path. (I've also double checked, and that version does work locally)
👋 Hey,
The Webassembly language was recently added (in #6429). I tested it today on the live enviornment, and it appears to not be working (example: https://godbolt.org/z/YP5KdscEM).
I don't really know how to debug this, there is no other output other than
objdump returned 255
which doesn't tell me a whole lot. (If someone can help me investigate this it would be appreciated)Looking at the configs for the other languages, they always specify a objdump binary in the
/opt
path, so maybellvm-objdump
is not available in the system?This PR attempts to fix it by changing to a fixed version of
llvm-objdump
in the/opt
install path. (I've also double checked, and that version does work locally)