-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to build and find stable branch #1
Conversation
@mattgodbolt I am opening this pull request primarily to answer the question you asked about which branch to build. I have answered that in the PR in the last section. But I will repeat again here. v8 releases are tied to chrome releases. And every time a chrome release happens a new branch is created in v8 for that release. The name of this branch can be found for linux by looking up the I built this docker image today on my local machine but I didn't see the build.sh file inside the /root directory. I am not sure why that is the case. But Ill figure it out and try running the build.sh script. However one line would require a change in the build.sh file. Namely
will have to be changed to
As this blog post is saying https://v8.dev/docs/release-process. the I will try to figure out why the build.sh is not showing up in my container, as well as write a small script to get the latest of these numbers out of omahaproxy automatically. Meanwhile please tell me if you know which one of these stable versions should be put up on ce. |
When our documentation says "use the tip of the branch" (in this case
That is incorrect. The V8
Be advised that omahaproxy is (unfortunately) going away in a few weeks. |
@jakobkummerow thankyou for helping 😊 🙇. @mattgodbolt so to get the latest version we can just list the branches that start with |
@mattgodbolt @jakobkummerow I have updated the readme with a command at the end to find the latest version. I used chat-gpt to generate that command. @mattgodbolt note that the change I mentioned in my first comment is not needed thanks to the information that @jakobkummerow provided. I am not sure how ce figures out which version it should give the build command, but you can get that version using the command in the last section of the readme in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! i appreciate the documentation; though I have a number of comments about how to improve it, and a query about the part at the end.
I have updated the PR to add the changes as you suggested. Also I have fixed the error in the last command. That was a paste error because of my windows terminal. Although I have updated the shell command as you suggested, I use a permanent container instead of a temporary one. Because I just restart that container and do stuff with the d8 executable and then stop it again. But I guess anyone who is going to set this much up can figure out how to make a persistent container as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I will update my PR compiler-explorer/compiler-explorer#4721 today to use the build made by this container. |
Thanks @gautam1168 for your patience in this. |
I am over here thinking you must be getting annoyed by the slow pace at which I'm doing things. I assure you I myself am thoroughly enjoying this experience. And I love it every time @jakobkummerow responds to correct something I'm doing as well. I hope I don't end up annoying him and driving him away either 😅. I am fascinated by v8 and I welcome any opportunity to learn more about it. |
No description provided.