Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add newer dotnet versions #1155

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

kasperk81
Copy link
Contributor

8.0 and minor versions of 6 & 7

Copy link
Member

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mattgodbolt mattgodbolt merged commit 76ca019 into compiler-explorer:main Nov 21, 2023
@mattgodbolt
Copy link
Member

7.0.14 Failed to build: https://github.com/compiler-explorer/infra/actions/runs/6963712242/job/18949761185

  MSBuild version 17.4.8+6918b863a for .NET
    Determining projects to restore...
  /tmp/app/app.csproj : error NU1101: Unable to find package Microsoft.AspNetCore.App.Runtime.linux-x64. No packages exist with this id in source(s): /root/dotnet/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/aot
  /tmp/app/app.csproj : error NU1102: Unable to find package runtime.linux-x64.Microsoft.DotNet.ILCompiler with version (= 7.0.12)
  /tmp/app/app.csproj : error NU1102:   - Found 1 version(s) in /root/dotnet/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/aot [ Nearest version: 7.0.14 ]```
  
  I have no idea how to fix that, unfortauntely

@mattgodbolt
Copy link
Member

v8.0.0 failed too. Only v6.0.25 built OK. I filed a bug in the dotnet repo: any help you can offer is appreciated.

@hez2010
Copy link
Contributor

hez2010 commented Nov 24, 2023

I have no idea how to fix that, unfortauntely

@mattgodbolt A temporary workaround is to disable AOT build, i.e. setting AOT_BUILD_NEEDED=0 here: https://github.com/compiler-explorer/dotnet-builder/blob/e10c3b9e267dae1dedafc22748c75f7e0b2c9ad8/build/build.sh#L20

While the real fix should be adding nuget.org as source as well (maybe a nuget.config file is necessary) because dotnet publish needs to download the runtime package: https://github.com/compiler-explorer/dotnet-builder/blob/e10c3b9e267dae1dedafc22748c75f7e0b2c9ad8/build/build.sh#L95

@partouf
Copy link
Contributor

partouf commented Nov 24, 2023

I'm assuming this is about the template app that's used? Then it should download the runtime packages during this buildscript, yes. And after publish and downloading, it should probably be removed again so it won't be tempted to access the internet from the compiler instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants