Add test only if Paths is included

Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>
compiler-research · Jan 28, 2024 · bd8d0e9 · bd8d0e9
1 parent d107d24
commit bd8d0e9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/Interpreter/Paths.cpp b/lib/Interpreter/Paths.cpp
@@ -108,15 +108,15 @@ namespace platform {
 
 #if defined(_WIN32)
   void* DLOpen(const std::string& Path, std::string& Err /* = nullptr */) {
-    auto lib = llvm::sys::DynamicLibrary::getLibrary(Path.c_str(), Err);
+    auto lib = llvm::sys::DynamicLibrary::getLibrary(Path.c_str(), &Err);
     return lib.getOSSpecificHandle();
   }
 
   void DLClose(void* Lib, std::string& Err /* = nullptr*/) {
     auto dl = llvm::sys::DynamicLibrary(Lib);
     llvm::sys::DynamicLibrary::closeLibrary(dl);
-    if (Err) {
-      *Err = std::string();
+    if (Err.empty()) {
+      Err = std::string();
     }
   }
 #else

diff --git a/unittests/CppInterOp/DynamicLibraryManagerTest.cpp b/unittests/CppInterOp/DynamicLibraryManagerTest.cpp
@@ -59,10 +59,10 @@ TEST(DynamicLibraryManagerTest, Sanity) {
 
 TEST(UtilsPlatform, DLTest) {
   std::string err = "";
-#ifdef __APPLE__
+#if defined(__APPLE__)
   auto dlopen_handle = Cpp::utils::platform::DLOpen(
       "./unittests/CppInterOp/libTestSharedLib.dylib", err);
-#elif defined(__WIN32__)
+#elif defined(_WIN32)
   auto dlopen_handle = Cpp::utils::platform::DLOpen(
       "./unittests/CppInterOp/libTestSharedLib.dll", err);
 #else