Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta 5 #131

Merged
merged 251 commits into from
Jun 3, 2024
Merged

Beta 5 #131

merged 251 commits into from
Jun 3, 2024

Conversation

jthrilly
Copy link
Member

@jthrilly jthrilly commented May 13, 2024

Outstanding tasks from RSC refactor:

  • Remove history push from navigation buttons
  • There is a visual glitch when loading a name generator. it looks like the nodes suddenly move upwards after animating in.
  • We need a plan for data migration - either we go back to lucia auth v2, or we figure out how to run migrations in production. Interestingly, drizzle can do this seemingly without any issues: https://youtube.com/watch?v=dHTGEQnogPw. It keeps track of which migrations have been applied in a special migrations table in the DB. This is so obvious that I can't believe prisma doesn't also do it. Have we missed something?
  • Activity table pagination, type, filter, etc is not re-rendering the table without a hard refresh (separate PR now)
  • Reimplement error messaging for incorrect username & password
  • Delete participant confirmation dialog doesn't close after clicking continue
  • Importing multiple protocols at the same time causes all import toasts to re-render any time any of them updates.
  • Limit interviews not working
  • Exporting interview with 0% progress fails

@jthrilly
Copy link
Member Author

jthrilly commented Jun 3, 2024

Via @buckhalt:

  • changes to the analytics package are causing errors in prod due to not having access to window.location. this is the cause of one bug on file export, creating an interview, and finishing an interview
  • exporting data was still failing due to uploadthing bug which is fixed by updating that package
  • there’s an issue with the getBaseUrl funciton and its use of VERCEL_URL. we need to rethink how we’re getting the url.
  • there may still be an issue with gateway timeout on analytics reporting. this could just be related to the issues with the analytics package update though.

clone and mutate request url to use absolute url for redirect. remove VERCEL_URL from env as it is no longer needed. remove getBaseUrl util as it is now unused file
@buckhalt buckhalt merged commit 632e710 into main Jun 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants