Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node animation in NameGenerator #137

Closed
wants to merge 2 commits into from

Conversation

mrkarimoff
Copy link
Collaborator

This PR fixes node animation with the following changes:

  • Updates framer-motion to the latest (11.2.6)
  • Removes the layout attribute in NodeTransition component

(FYI: I tried everything and the only solutions that worked were either setting y: '20%' rather than y: '3rem' or removing the layout attribute)

Open to any suggestions!

Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fresco-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 4:51pm

@jthrilly
Copy link
Member

Removing the layout element will prevent nodes from animating position when nodes enter or leave the container. That's not a viable solution.

@jthrilly jthrilly closed this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants