Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/active protocol #15

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Feature/active protocol #15

merged 5 commits into from
Sep 27, 2023

Conversation

buckhalt
Copy link
Member

Implement the concept of currently 'active' protocol

When a new protocol is added via the ProtocolUploader, the user can decide if they want to mark it as active.
If marked as active, the other protocols will be marked as inactive.

Screenshot 2023-09-22 at 12 39 35 PM

this works for usage on protocol uploader bc is part of the upload process and we can't get hash. when adapting this functionality for protocols datatable, will need to change setActive to accept an optional unique id for protocol to set as active
this will allow for setting a specific protocol as active from the dashboard when we do have the hash
Copy link
Collaborator

@mrkarimoff mrkarimoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any problems in your code. This looks good

@jthrilly jthrilly merged commit 2304f76 into main Sep 27, 2023
@jthrilly jthrilly deleted the feature/active-protocol branch April 16, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants