Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/settings menu #51

Merged
merged 9 commits into from
Jan 17, 2024
Merged

Feature/settings menu #51

merged 9 commits into from
Jan 17, 2024

Conversation

buckhalt
Copy link
Member

Implements an Interview Settings menu using a sheet. Currently supports the "Use experimental interaction sounds?" setting.

includes settings menu sheet, tabs for visual or audio, toggle setting components, and interface scale dropdown
connects new ui to enableExperimentalSounds state and action to toggle it
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fresco ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 5:12pm

Copy link
Member

@jthrilly jthrilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like the slide over fullscreen menu is overkill now we only have one option honestly, but in terms of the implementation of the feature its spot on.

Copy link
Member

@jthrilly jthrilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the changes I've marked in the comments, then good to merge.

lib/interviewer/components/SettingsMenu/InterfaceScale.tsx Outdated Show resolved Hide resolved
lib/interviewer/components/SettingsMenu/SettingsMenu.tsx Outdated Show resolved Hide resolved
lib/interviewer/components/SettingsMenu/ToggleSetting.tsx Outdated Show resolved Hide resolved
delete SettingsMenu folder and move SettingsMenu component up to components
@buckhalt buckhalt merged commit 168cce8 into main Jan 17, 2024
3 checks passed
@jthrilly jthrilly deleted the feature/settings-menu branch April 16, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants