-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/alternate before next #85
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…better animation sync
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…reimplementing FORCE option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a completely rewritten navigation system, with the aim of fixing the problems with the
registerBeforeNext
functionality.Specific changes:
useNavigationHelpers
hook, and implement all navigation methods inside ofProtocolScreen
.Stage
andNavigation
, and use selectors within those components for everything else.registerBeforeNext
- passed in to Stage, and automatically set tonull
within ProtocolScreen just prior to triggering the stage animation.stage
- got via redux selector and passed directly into Stage and through to the stage component.getNavigationHelpers
- heavily memoised function that returnsmoveForward
andmoveBackward
functions, which can be used where needed by the stage. As far as I know, there are only three instances where these are used: TieStrengthCensus & DyadCensus (both for the 'auto advance' functionality), and SlidesForm (uses it to allow pressing enter to advance.useSteps
anduseEdgeState
and tried to combine as much code between the two interfaces as possible.