Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flex-launcher does not wait long enough for a program to start. #30

Closed
xslushedx opened this issue Mar 10, 2023 · 8 comments
Closed

flex-launcher does not wait long enough for a program to start. #30

xslushedx opened this issue Mar 10, 2023 · 8 comments

Comments

@xslushedx
Copy link

xslushedx commented Mar 10, 2023

If a program takes longer to start, the flex launcher remains visible in the foreground. I have that, for example, with emulationstaion. Because i have a big rom collection it takes a moment to start.

@complexlogic
Copy link
Owner

complexlogic commented Mar 10, 2023 via email

@xslushedx
Copy link
Author

With a fresh Windows 10 start, emulationstation actually needs seven to eight seconds to start. That is of course very long. I have now created a batch file to launch it and flex-launcher is working fine.

@sekmo
Copy link

sekmo commented Apr 24, 2023

is the waiting time configurable?

@complexlogic
Copy link
Owner

is the waiting time configurable?

No, but it would be relatively easy to add one. Are you having this same issue?

@sekmo
Copy link

sekmo commented May 5, 2023

Yeah, unfortunately I have a game that takes around 10 seconds and even the screen is showing the game, the focus is kept on flexlauncher :/

@sekmo
Copy link

sekmo commented May 5, 2023

If you could guide me on where to look around for implementing this feature, I would be more than happy to submit a PR! :)

@complexlogic
Copy link
Owner

@sekmo The timeout value is controlled by a macro defined here. You will need to convert this into a config option.

  1. Add a new int variable to the Config struct declaration (in launcher.h)
  2. Define the setting key and default value in config/config_settings.cmake
  3. Make those CMake variables available to the program in config/launcher_config.h.in
  4. Initialize the new variable in launcher.c
  5. Add the setting and default value to the default config file in config/config.ini.in
  6. Parse for the new config setting in util.c. The setting facing the user should be in seconds, but the program uses milliseconds internally so you'll need to multiply it by 1000.

If you are not able to do this, then let me know and I can do it.

@sekmo
Copy link

sekmo commented Jul 11, 2023

Omg thank you so much!
(Sorry if I didn't get back on this, I was eager to help out but I didn't have in the last period :/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants