fix(app): disableLifeCycleHooks for pipes and services

fix #1369
compodoc · Aug 16, 2023 · 753b74d · 753b74d
1 parent 791f421
commit 753b74d
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 1 deletion.
diff --git a/src/app/compiler/angular-dependencies.ts b/src/app/compiler/angular-dependencies.ts
@@ -468,6 +468,11 @@ export class AngularDependencies extends FrameworkDependencies {
                             if (IO.extends) {
                                 injectableDeps.extends = IO.extends;
                             }
+                            if (Configuration.mainData.disableLifeCycleHooks) {
+                                injectableDeps.methods = cleanLifecycleHooksFromMethods(
+                                    injectableDeps.methods
+                                );
+                            }
                             deps = injectableDeps;
                             if (typeof IO.ignore === 'undefined') {
                                 if (_.includes(IO.implements, 'HttpInterceptor')) {
@@ -509,6 +514,9 @@ export class AngularDependencies extends FrameworkDependencies {
                                     srcFile.getText()
                                 )
                             };
+                            if (Configuration.mainData.disableLifeCycleHooks) {
+                                pipeDeps.methods = cleanLifecycleHooksFromMethods(pipeDeps.methods);
+                            }
                             if (IO.jsdoctags && IO.jsdoctags.length > 0) {
                                 pipeDeps.jsdoctags = IO.jsdoctags[0].tags;
                             }

diff --git a/test/fixtures/sample-files/bar.pipe.ts b/test/fixtures/sample-files/bar.pipe.ts
@@ -0,0 +1,13 @@
+import { PipeTransform, Pipe, OnDestroy } from '@angular/core';
+
+@Pipe({
+    name: 'bar',
+    standalone: true
+})
+export class BarPipe implements PipeTransform, OnDestroy {
+    transform(value, args) {
+        return 'StandAlone Pipe ;)';
+    }
+
+    ngOnDestroy(): void {}
+}
diff --git a/test/fixtures/sample-files/bar.service.ts b/test/fixtures/sample-files/bar.service.ts
@@ -1,4 +1,6 @@
 import { Injectable } from '@angular/core';
 
 @Injectable()
-export class BarService {}
+export class BarService implements OnDestroy {
+    ngOnDestroy(): void {}
+}
diff --git a/test/src/cli/cli-disable-options.spec.ts b/test/src/cli/cli-disable-options.spec.ts
@@ -167,6 +167,10 @@ describe('CLI disable flags', () => {
             expect(componentFile).not.to.contain('<code>ngOnInit');
             const directiveFile = read(`${distFolder}/directives/BarDirective.html`);
             expect(directiveFile).not.to.contain('<code>ngOnInit');
+            const pipeFile = read(`${distFolder}/pipes/BarPipe.html`);
+            expect(pipeFile).not.to.contain('<code>ngOnDestroy');
+            const serviceFile = read(`${distFolder}/injectables/BarService.html`);
+            expect(serviceFile).not.to.contain('<code>ngOnDestroy');
         });
 
         it('should include methods marked as private', () => {