Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Coverage does not ignore private members with TypeScript 2.5 #332

Closed
stogle opened this issue Oct 16, 2017 · 2 comments
Closed

[BUG] Coverage does not ignore private members with TypeScript 2.5 #332

stogle opened this issue Oct 16, 2017 · 2 comments

Comments

@stogle
Copy link

stogle commented Oct 16, 2017

Overview of the issue

Compodoc is not ignoring private members in document coverage.

Operating System, Node.js, npm, compodoc version(s)

Compodoc: 1.0.1
Node.js version : v6.11.3
Operating system : Windows 8.1

Angular configuration, a package.json file in the root folder

Occurs in the live demo as well

Compodoc installed globally or locally ?

Locally

Motivation for or Use Case

Incorrect coverage data.

Reproduce the error

In the live demo note the coverage for EmitterService is 33%, not 50%. The private _emitters properties is being included in the calculation.
https://compodoc.github.io/compodoc-demo-todomvc-angular/coverage.html

Related issues

I believe this is due to incorrect SyntaxKind IDs just like #197.

Suggest a Fix

I think 111 should be replaced with 112 in the following lines:

https://github.com/compodoc/compodoc/blob/master/src/app/application.ts#L989-L1187

@seekheart
Copy link

I don't think Angular supports TS > 2.4 as of yet?

@lock
Copy link

lock bot commented Oct 1, 2019

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem. Why locking ? Having issues with the most up-to-date context.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants