Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): remove trailing commas from routes #1451

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

raizorlol
Copy link
Contributor

@raizorlol raizorlol commented Apr 1, 2024

Fixes "Routes parsing error, maybe a trailing comma or an external variable, trying to fix that later after sources scanning." error when that error occurs due to trailing commas (by removing trailing commas for all possible cases) + a bit of refactoring

@vogloblinsky
Copy link
Contributor

Hi,
thanks for this great PR.
Is it possible to add unit tests ?
I can guide you if needed.

@raizorlol
Copy link
Contributor Author

Done. The check was added inside the existing test case that tests loadChildren syntax because trailing comma is a possible part of that syntax.

@vogloblinsky
Copy link
Contributor

Thanks !

@vogloblinsky vogloblinsky merged commit 8b199a8 into compodoc:develop Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants