Improve addEventListener and removeEventListener support. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need some benchmark results showing this is faster in order to merge this. |
|
http://jsperf.com/event-component Done! :) |
|
Seems fine to me then. Could probably be even more optimized by defining separate hard-coded paths for each version, but this is an improvement. Thanks! |
TooTallNate
added a commit
that referenced
this pull request
Nov 12, 2013
Improve addEventListener and removeEventListener support.
| @@ -1,3 +1,6 @@ | |||
| var bind = (window.addEventListener !== undefined) ? 'addEventListener' : 'attachEvent', | |||
| unbind = (window.removeEventListener !== undefined) ? 'removeEventListener' : 'detachEvent', | |||
There was a problem hiding this comment.
The parentheses are not needed, nor is the comparison with undefined.
There was a problem hiding this comment.
I'm going to do a new pull request with these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eventchecks ifaddEventListenerandremoveEventListenermethods are supported by the browser, just once. Also, checks if the event need the prefixon.Thanks.