Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling undefined, null, false for data-text & data-value #11

Closed
matthewmueller opened this issue Dec 29, 2012 · 1 comment
Closed

Comments

@matthewmueller
Copy link
Member

Right now they will show up literally as undefined, null, & false. Personally I think that undefined and null should probably just be ignored (use the defaults). So in:

<span class="tag" data-text="tag">tag</span>
<input class="url" data-value="url" placeholder="url...">

These values would default back to tag and blank (leading to url... as placeholder).

I think false might be good to either show or not show, but I think that's covered in another attribute.

@tj
Copy link
Member

tj commented May 18, 2013

this will get easier with #45

@tj tj closed this as completed May 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants