-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider removing data-* in place of interpolation #45
Comments
Would be nice to have for content, but I have it's quite the hot part for attributes |
yeah we'll see! sucks you cant do |
got most of it working really well so far, pretty happy with it, just need to polish things up and I'll merge to master |
Yay! |
wow, this looks really sweet |
With the old style you could set a default with the regular attribute before the JS loaded, e.g. now there's a possibility of broken links if users click things before the page has fully loaded. Probably not a problem worth solving given this api is far less cumbersome. Nice job. |
@timoxley for SPAs like ours it doesn't matter much since the content itself wouldn't be loaded yet either but that's a good point |
related to #44. This would be more expensive in terms of walking the dom tree to discover bindings but if we measure this out and it's reasonable it would probably be worth it. Ex:
vs
The text was updated successfully, but these errors were encountered: