-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite in co generators #5
Conversation
I'm down in concept, but please don't remove already working features. I spent a good amount of time making proxy and auth support consistent in this module. |
@TooTallNate i don't plan to ever merge it without readding auth and proxy support, but i do need tests to make sure it's working correctly. |
@jonathanong Sounds good, just checking :) |
@TooTallNate please add tests :) also, auth/proxy support in cogent or fixing super agent in general would be nice too. |
@TooTallNate looking at your proxy stuff, it seems that all that's needed is |
@jonathanong I think you mean We can also take a look at |
cool. much easier than i thought. shouldn't be difficult. i was confused because it seems like you tested using a local proxy, but you don't have any comments or references on how i could create a local proxy as well. an proxy included with the tests (maybe even optional like how you're doing it right now) using proxy would be helpful. |
rewritten with the following changes:
to do:
right now it works, but there are a lot of tests to be had. it's already much cleaner.