Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring, updates and fixes with tests #77

Merged
merged 16 commits into from
May 26, 2020
Merged

Refactoring, updates and fixes with tests #77

merged 16 commits into from
May 26, 2020

Conversation

silverbackdan
Copy link
Collaborator

@silverbackdan silverbackdan commented May 20, 2020

  • remove token authenticator, will not be needed with new refresh token workflow.
  • Fix routes and layouts data providers
  • Add uuid normalizer decorating API Platform normalizer to allow soft fails
  • Update class/property names - PageTemplate -> Page, Route::$route -> Route::$path
  • Route redirect normalization, prevent need for additional requests for redirects.
  • Test and solidify Layout implementation
  • Removed 'default' option for a Layout
  • update layout documentation
  • Document getting started and terminology
  • Test and solidify page implementation
  • Document page implementation
  • Document Route implementation
  • Document component collections
  • Check tests for component collections
  • Test component positions
  • Implement component positions auto sorting and re-sorting if duplicate sort value
  • Document component positions
  • Document creating a component

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #77 into master will decrease coverage by 0.70%.
The diff coverage is 83.27%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #77      +/-   ##
============================================
- Coverage     92.35%   91.64%   -0.71%     
- Complexity     1020     1083      +63     
============================================
  Files           135      137       +2     
  Lines          2734     2922     +188     
============================================
+ Hits           2525     2678     +153     
- Misses          209      244      +35     
Flag Coverage Δ Complexity Δ
#behat 73.86% <57.06%> (+1.46%) 1083.00 <101.00> (+63.00)
#phpunit 43.92% <42.17%> (-4.32%) 1083.00 <101.00> (+63.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
src/Entity/Core/Page.php 100.00% <ø> (ø) 1.00 <0.00> (?)
src/EventListener/Api/FormSubmitEventListener.php 100.00% <ø> (ø) 16.00 <0.00> (ø)
...c/EventListener/Form/EntityPersistFormListener.php 94.28% <ø> (ø) 11.00 <0.00> (ø)
src/Model/Form/FormView.php 91.66% <ø> (ø) 22.00 <0.00> (ø)
src/Repository/Core/LayoutRepository.php 100.00% <ø> (ø) 1.00 <0.00> (-1.00)
src/Validator/Constraints/ComponentPosition.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
...Validator/Constraints/NewEmailAddressValidator.php 100.00% <ø> (ø) 7.00 <0.00> (ø)
src/Entity/Core/ComponentCollection.php 16.66% <13.04%> (-83.34%) 17.00 <16.00> (+16.00) ⬇️
...encyInjection/SilverbackApiComponentsExtension.php 69.56% <29.26%> (+1.93%) 14.00 <0.00> (ø)
src/Command/UserCreateCommand.php 76.56% <40.90%> (-1.22%) 13.00 <0.00> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab81b8...6893c1b. Read the comment docs.

@silverbackdan silverbackdan changed the title Fixes #75 - refresh token delete on logout Refactoring, updates and fixes with tests May 21, 2020
@silverbackdan silverbackdan force-pushed the issue/75 branch 2 times, most recently from cdc87bf to 9224680 Compare May 21, 2020 14:08
@silverbackdan silverbackdan merged commit decdb43 into master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants