-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring, updates and fixes with tests #77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
silverbackdan
commented
May 20, 2020
•
edited
Loading
edited
- remove token authenticator, will not be needed with new refresh token workflow.
- Fix routes and layouts data providers
- Add uuid normalizer decorating API Platform normalizer to allow soft fails
- Update class/property names - PageTemplate -> Page, Route::$route -> Route::$path
- Route redirect normalization, prevent need for additional requests for redirects.
- Test and solidify Layout implementation
- Removed 'default' option for a Layout
- update layout documentation
- Document getting started and terminology
- Test and solidify page implementation
- Document page implementation
- Document Route implementation
- Document component collections
- Check tests for component collections
- Test component positions
- Implement component positions auto sorting and re-sorting if duplicate sort value
- Document component positions
- Document creating a component
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
============================================
- Coverage 92.35% 91.64% -0.71%
- Complexity 1020 1083 +63
============================================
Files 135 137 +2
Lines 2734 2922 +188
============================================
+ Hits 2525 2678 +153
- Misses 209 244 +35
Continue to review full report at Codecov.
|
silverbackdan
changed the title
Fixes #75 - refresh token delete on logout
Refactoring, updates and fixes with tests
May 21, 2020
silverbackdan
force-pushed
the
issue/75
branch
2 times, most recently
from
May 21, 2020 14:08
cdc87bf
to
9224680
Compare
…er which only loaded the default layout into the page if it wasn't defined
…in for different roles in a component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.