Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh token #83

Merged

Conversation

vincentchalamon
Copy link
Contributor

No description provided.

@silverbackdan silverbackdan linked an issue May 29, 2020 that may be closed by this pull request
@vincentchalamon vincentchalamon force-pushed the refresh-token branch 5 times, most recently from 21da9d5 to 918703e Compare May 29, 2020 14:43
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2020

Codecov Report

Merging #83 into master will decrease coverage by 3.35%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #83      +/-   ##
============================================
- Coverage     92.02%   88.67%   -3.36%     
- Complexity     1106     1160      +54     
============================================
  Files           138      146       +8     
  Lines          2973     3143     +170     
============================================
+ Hits           2736     2787      +51     
- Misses          237      356     +119     
Flag Coverage Δ Complexity Δ
#behat 71.08% <7.69%> (-3.47%) 1160.00 <54.00> (+54.00) ⬇️
#phpunit 41.97% <51.33%> (-1.25%) 1160.00 <54.00> (+54.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
src/Command/RefreshTokensExpireCommand.php 0.00% <0.00%> (ø) 5.00 <5.00> (?)
src/Event/JWTRefreshedEvent.php 0.00% <0.00%> (ø) 2.00 <2.00> (?)
src/RefreshToken/RefreshToken.php 0.00% <0.00%> (ø) 10.00 <10.00> (?)
src/Repository/Core/RefreshTokenRepository.php 0.00% <0.00%> (ø) 4.00 <4.00> (?)
src/Security/Http/Logout/LogoutHandler.php 0.00% <0.00%> (ø) 2.00 <2.00> (?)
...freshToken/Storage/DoctrineRefreshTokenStorage.php 15.15% <15.15%> (ø) 12.00 <12.00> (?)
src/Services/JWTManager.php 34.28% <34.28%> (ø) 12.00 <12.00> (?)
src/EventListener/Jwt/JWTEventListener.php 78.57% <57.14%> (ø) 5.00 <4.00> (?)
...ncyInjection/CompilerPass/SecurityCompilerPass.php 75.00% <75.00%> (ø) 1.00 <1.00> (?)
...encyInjection/SilverbackApiComponentsExtension.php 71.89% <93.33%> (+2.33%) 16.00 <0.00> (+2.00)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8cbebc...9d266a3. Read the comment docs.

@vincentchalamon vincentchalamon force-pushed the refresh-token branch 2 times, most recently from 4e702ed to 128553c Compare May 29, 2020 14:57
@vincentchalamon vincentchalamon changed the title WIP: Refresh token Refresh token May 29, 2020
@vincentchalamon vincentchalamon marked this pull request as ready for review May 29, 2020 15:21
@silverbackdan silverbackdan merged commit f2f2a81 into components-web-app:master May 29, 2020
@vincentchalamon vincentchalamon deleted the refresh-token branch May 29, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh tokens
3 participants