Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember.prod.js not available in canary branch #59

Closed
zigomir opened this issue May 7, 2014 · 6 comments
Closed

ember.prod.js not available in canary branch #59

zigomir opened this issue May 7, 2014 · 6 comments

Comments

@zigomir
Copy link

zigomir commented May 7, 2014

Would be good to have it, since ember-cli is depending on it.

ember-cli issue reference

@leepfrog
Copy link

Ditto, just ran into this when updating to canary.

@stefanpenner
Copy link

the cdn does have it, but agree at some point it would be great of components also did. Maybe someone can offer time/energy to help rob and the release team out? (I believe they are maxed out right now)

@leepfrog
Copy link

@stefanpenner no clue how the build system is setup, but is it as simple as adding in ember-prod to this?:

https://github.com/emberjs/ember.js/blob/master/Rakefile#L163

@rwjblue
Copy link
Contributor

rwjblue commented Jun 11, 2014

@leepfrog the ember.prod.js is published with each build to the S3 bucket. That line you linked to only references the base files, but each of those will upload a prod.js and min.js variant if they exist on disk.

See http://emberjs.com/builds/#/canary for the most recent builds.

@rwjblue
Copy link
Contributor

rwjblue commented Jun 11, 2014

I believe that this issue was originally created referring to the canary branch of the bower repo, which is not properly being kept in sync.

I am going to try and work on this a bit over the weekend. If I can't get it working quicklyish I'll likely delete the branches in the bower repo as they are quite out of date now...

@fivetanley
Copy link
Contributor

This seems to be working now. Feel free to reopen if it stops working, but I see the .prod.js files on the canary branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants