Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 1.0.0 version. #9

Merged
merged 1 commit into from
Jun 6, 2013
Merged

Conversation

appleboy
Copy link
Contributor

@appleboy appleboy commented Jun 3, 2013

Signed-off-by: Bo-Yi Wu appleboy.tw@gmail.com

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@w33ble
Copy link

w33ble commented Jun 3, 2013

+1

There was a change in the 1.0.12 build code that breaks versions less than 1.0.0. See gruntjs/grunt-contrib-handlebars#55 and handlebars-lang/handlebars.js#547

RobLoach added a commit that referenced this pull request Jun 6, 2013
@RobLoach RobLoach merged commit 872051b into components:master Jun 6, 2013
@RobLoach
Copy link
Member

RobLoach commented Jun 6, 2013

Should we open a new issue for 1.0.12?

@w33ble
Copy link

w33ble commented Jun 6, 2013

1.0.12 is the server-side version. The front-end version (the only part Bower repos really care about) is 1.0.0. If you pre-compile with 1.0.12, you need the 1.0.0 runtime to use the compiled templates.

If you take a look at the dist path in https://github.com/wycats/handlebars.js/tree/v1.0.12, you'll see that the runtime is 1.0.0.

@RobLoach
Copy link
Member

RobLoach commented Jun 6, 2013

Ah, great! Thanks for the explaination, @w33ble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants