-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated jQuery to 1.10.2 #3
Conversation
Boilerplate HTML5 4.3 uses jquery 1.10.2
@@ -9,7 +9,7 @@ | |||
"homepage": "http://html5boilerplate.com", | |||
"license": "MIT", | |||
"require": { | |||
"components/jquery": ">=1.9.1", | |||
"components/jquery": ">=1.10.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must be "components/jquery": "1.10.", otherwise it'll use always jquery 2. ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
giving the >=
as prefix it should accept all versions equal or major to 1.10.2
(so also 1.10.3
, 1.10.4
and so on will be accepted)
So it's like writing 1.10.*
, but *
should be greater or equal 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hum, home, if I let the >=
as prefix, composer using the latest version of jquery.
php composer.phar update components/jquery
Loading composer repositories with package information
Updating dependencies (including require-dev)
- Removing components/jquery (1.10.2)
- Installing components/jquery (2.0.3)
Loading from cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmmm... interesting!
What about using >=1.10.2,<2.11-dev
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same result
php composer.phar update components/jquery
Loading composer repositories with package information
Updating dependencies (including require-dev)
- Removing components/jquery (1.10.2)
- Installing components/jquery (2.0.3)
Loading from cache
Using >=1.10.2,<2.0
works:
php composer.phar update components/jquery
Loading composer repositories with package information
Updating dependencies (including require-dev)
- Removing components/jquery (2.0.3)
- Installing components/jquery (1.10.2)
Loading from cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry the correct one should be >=1.10.2,<1.11-dev
!
And I can confirm it works:
{
"require": {
"components/jquery": ">=1.10.2,<1.11-dev"
}
}
$ composer install
Loading composer repositories with package information
Installing dependencies (including require-dev)
- Installing symfony/process (v2.3.4)
Downloading: 100%
- Installing kriswallsmith/assetic (v1.1.2)
Downloading: 100%
- Installing robloach/component-installer (0.0.12)
Downloading: 100%
- Installing components/jquery (1.10.2)
Downloading: 100%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.10.~
should work
Fixed version (to be major or equal 1.10.2 and lower than 1.11)
Thanks. |
Boilerplate HTML5 4.3 uses jQuery 1.10.2