Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw an error when contains stmt or comp stmt are applied on a non-existent field #52

Closed
marcauberer opened this issue Jun 23, 2021 · 0 comments · Fixed by #54
Closed
Assignees
Labels
improvement Improves an existing feature

Comments

@marcauberer
Copy link
Member

For Compose Generator we have following single statement:

services.database contains name == "elasticsearch"

This is problematic, because currently CCom terminates with an error if the key services.database does not exist. Same thing for compStmts.
As we currently only support a logical or (|) and no logical and, we cannot check if the key services.database exists before executing the statement above.

A solution for that would be to simply evaluate comp and contain statements to false if the key does not even exist.

@marcauberer marcauberer added the improvement Improves an existing feature label Jun 23, 2021
@marcauberer marcauberer self-assigned this Jun 23, 2021
@marcauberer marcauberer added this to To do - staging in C++ Compiler via automation Jun 23, 2021
marcauberer added a commit that referenced this issue Jun 25, 2021
C++ Compiler automation moved this from To do - staging to Done Jun 27, 2021
marcauberer added a commit that referenced this issue Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing feature
Projects
Development

Successfully merging a pull request may close this issue.

1 participant