Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple configurations causes Duplicate Key exception #61

Closed
smudge202 opened this issue May 18, 2015 · 3 comments · Fixed by #79
Closed

Multiple configurations causes Duplicate Key exception #61

smudge202 opened this issue May 18, 2015 · 3 comments · Fixed by #79
Assignees
Labels
Milestone

Comments

@smudge202
Copy link
Collaborator

There are legitimate cases for having bindings that differ by Implementation Type (relying on duplicate Service Types):
image

However, these cause Duplicate Key Exceptions when registering singletons in WrappedServiceProvider:

https://github.com/smudge202/compose/blob/dev/src/Compose/WrappedServiceProvider.cs#L17

@smudge202 smudge202 added the bug label May 18, 2015
@smudge202 smudge202 added this to the 0.1.4-beta milestone May 18, 2015
@smudge202
Copy link
Collaborator Author

Likely caused by this: smudge202@3605ffe

@smudge202
Copy link
Collaborator Author

As per https://github.com/aspnet/Options/blob/dev/src/Microsoft.Framework.OptionsModel/OptionsManager.cs#L37 the options model is designed as an aggregation/additive configuration model. We're hitting this issue increasingly frequently at 4Com.

@smudge202
Copy link
Collaborator Author

This has been resolved as part of the structural change found here: 4Com/compose#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant