add mapping for ssh property in build section #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
ndeloof
reviewed
Mar 4, 2022
loader/loader_test.go
Outdated
| test: | ||
| build: | ||
| context: . | ||
| ssh: ssh-agent |
There was a problem hiding this comment.
according to the spec proposal, should be default
types/types.go
Outdated
| @@ -426,6 +427,9 @@ func (l Labels) Add(key, value string) Labels { | |||
| return l | |||
| } | |||
|
|
|||
| // SSHConfig is a mapping type for SSH build config | |||
| type SSHConfig map[string]string | |||
There was a problem hiding this comment.
I wonder SSHConfig should be a []SSHKey, the latter declared as struct { ID, Path }` (to match the spec)
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
ndeloof
approved these changes
Mar 5, 2022
|
ready to merge, just waiting for compose-spec/compose-spec#234 to be approved |
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
glours
force-pushed
the
add-ssh-build
branch
2 times, most recently
from
5ca58af
to
814bb73
Compare
|
Is this all good to merge now ? The spec has been approved ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implement compose-spec/compose-spec#234