Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add secrets property to build section #236

Merged
merged 2 commits into from Apr 11, 2022
Merged

add secrets property to build section #236

merged 2 commits into from Apr 11, 2022

Conversation

glours
Copy link
Contributor

@glours glours commented Mar 10, 2022

@glours glours requested a review from ndeloof as a code owner March 10, 2022 09:48
@glours glours mentioned this pull request Mar 10, 2022
Open
@glours
add secrets property to build section
01cc80e 
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
@glours
define a json ref for service secrets and confids properties
c3a57cf 
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
@glours glours mentioned this pull request Mar 15, 2022
Closed
ulyssessouza
ulyssessouza approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit ef73f5a into compose-spec:master Apr 11, 2022
@ndeloof ndeloof mentioned this pull request Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndeloof ndeloof ndeloof approved these changes

@ulyssessouza ulyssessouza ulyssessouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glours @ndeloof @ulyssessouza