Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process include with a relative-path local resource loader #579

Merged
merged 1 commit into from Feb 16, 2024

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Feb 16, 2024

As we process include, use relative path to configure local resource loader so that included resources point to the target path, but still respect the --no-path-resolution flag

fixes docker/compose#11508

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit ede4e8e into compose-spec:main Feb 16, 2024
8 checks passed
@ndeloof ndeloof deleted the include_relative_path branch February 16, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] --no-path-resolution ineffective when using include
2 participants