Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish schema on http://schemastore.org/json/ #50

Closed
ndeloof opened this issue Feb 12, 2020 · 10 comments · Fixed by SchemaStore/schemastore#1164
Closed

Publish schema on http://schemastore.org/json/ #50

ndeloof opened this issue Feb 12, 2020 · 10 comments · Fixed by SchemaStore/schemastore#1164

Comments

@ndeloof
Copy link
Collaborator

ndeloof commented Feb 12, 2020

What is the problem you're trying to solve
schema can be used to offer IDE autocompletion and validation.

Describe the solution you'd like
schemastore.org do define an API for IDE to download schema
(https://www.jetbrains.com/help/idea/json.html)
we just have to publish compose schema to offer users autocompletion

Additional context
Initialy proposed by docker/compose#2089 (comment)

@keinsell
Copy link

keinsell commented Jul 22, 2020

@ndeloof Do somebody done that? Or maybe I should do it on my own? It would be usable for me and some time passed away since there was issues on it, I haven't seen that on schemastore.

@keinsell
Copy link

Ahhh... Fuck, I'll take part in this.

@keinsell
Copy link

Actually opened a PR to SchemaStore with docker-spec. Thanks for your awesome configuration, let's make it usable.

SchemaStore/schemastore#1153

@keinsell
Copy link

keinsell commented Jul 23, 2020

Merge completed, Awesome! 🎉

@ndeloof Issue can be closed :)

@EricHripko
Copy link
Collaborator

Thanks for your help with this @ZiQiLN 👍 I've asked the approver of your PR to confirm if we can simply link out to this repo. This would simplify maintenance, as schema would be referenced from one place (thereby avoiding duplication and the need to keep these in sync).

@keinsell
Copy link

Actually I made a little mistake with adding a schema in JSON, because in catalog I've added raw from your GitHub repo.

@EricHripko
Copy link
Collaborator

Ah, I see - sorry, didn't check the large diff. Would you like to submit a follow-up PR to finish that up or should we do it?

Also, we should add compose.y(a)ml to the fileMatch - as per the spec.

@keinsell
Copy link

keinsell commented Jul 24, 2020 via email

@EricHripko
Copy link
Collaborator

Resolved as per PRs above - thank you @ZiQiLN for helping out with this functionality 🙌

@AlexRMU
Copy link

AlexRMU commented Apr 15, 2024

The file is currently unavailable for some reason.
You can use this link: https://cdn.jsdelivr.net/gh/SchemaStore/schemastore@55438674c8ee173f6a0b23501c5c11a5fe1ed972/src/schemas/json/docker-compose.json
By the way, you forgot to add the $schema field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants