Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker-compose Specification #1153

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Added docker-compose Specification #1153

merged 1 commit into from
Jul 23, 2020

Conversation

keinsell
Copy link
Contributor

@keinsell keinsell commented Jul 22, 2020

Upfront sorry for my prettier configuration :/.

This PR stands for schema implementation for docker-compose based on compose-spec, I'm not an author of this schema but I had a problem on my side where schema would potentially help me and I haven't found that in your project, so I've decided to make this PR.

My Prettier fucked up code a bit, sorry. Here is a fresh `docker-compose` specification, orginal repository added in `catalog.json`
@keinsell
Copy link
Contributor Author

Reference to original issue: compose-spec/compose-spec#50

@madskristensen madskristensen merged commit f407432 into SchemaStore:master Jul 23, 2020
@madskristensen
Copy link
Contributor

Thanks

@keinsell
Copy link
Contributor Author

@madskristensen Do you have reviewed code? I'm not sure this works because it isn't available on the website - is this reason because I've put Github link in URL?

@madskristensen
Copy link
Contributor

github links are fine. But why have the docker-compose.json file uploaded to SchemaStore.org if you're point to the github one from the catalog?

@keinsell
Copy link
Contributor Author

keinsell commented Jul 24, 2020 via email

@EricHripko
Copy link
Contributor

@madskristensen so would it make sense / is it allowed to have "url": "https://raw.githubusercontent.com/compose-spec/compose-spec/master/schema/compose-spec.json"?

@madskristensen
Copy link
Contributor

@EricHripko Yes, you'll see that being used many places in catalog.json already

@keinsell
Copy link
Contributor Author

@EricHripko and @madskristensen I'll make a next PR tomorrow which will remove actually useless docker-compose.json and improve file resolution as @EricHripko suggested in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants