-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docker-compose Specification #1153
Added docker-compose Specification #1153
Conversation
My Prettier fucked up code a bit, sorry. Here is a fresh `docker-compose` specification, orginal repository added in `catalog.json`
Reference to original issue: compose-spec/compose-spec#50 |
Thanks |
@madskristensen Do you have reviewed code? I'm not sure this works because it isn't available on the website - is this reason because I've put Github link in URL? |
github links are fine. But why have the docker-compose.json file uploaded to SchemaStore.org if you're point to the github one from the catalog? |
Yeah, I messed a bit because I wanted to implement docker-compose locally and then I though that connecting orginal GH repository will be better idea, and in effect I forgot to remove docker-compose.json, sorry.
…On Jul 23 2020, at 8:37 pm, Mads Kristensen ***@***.***> wrote:
github links are fine. But why have the docker-compose.json file uploaded to SchemaStore.org if you're point to the github one from the catalog?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub ***@***.***/0?redirect=https%3A%2F%2Fgithub.com%2FSchemaStore%2Fschemastore%2Fpull%2F1153%23issuecomment-663167332&recipient=cmVwbHkrQUo2NzYyNENFVFpDRUFVN01EM1g1VE41RVc0N0hFVkJOSEhDUEZGNEZJQHJlcGx5LmdpdGh1Yi5jb20%3D), or unsubscribe ***@***.***/1?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJ6762ZBOA3CLG3KCPVU2ZDR5B7PHANCNFSM4PFDSTVA&recipient=cmVwbHkrQUo2NzYyNENFVFpDRUFVN01EM1g1VE41RVc0N0hFVkJOSEhDUEZGNEZJQHJlcGx5LmdpdGh1Yi5jb20%3D).
|
@madskristensen so would it make sense / is it allowed to have |
@EricHripko Yes, you'll see that being used many places in catalog.json already |
@EricHripko and @madskristensen I'll make a next PR tomorrow which will remove actually useless |
Upfront sorry for my
prettier
configuration :/.This PR stands for schema implementation for
docker-compose
based oncompose-spec
, I'm not an author of this schema but I had a problem on my side where schema would potentially help me and I haven't found that in your project, so I've decided to make this PR.