Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs cleanup (typos, etc) #142

Merged
merged 2 commits into from
Feb 28, 2021
Merged

Docs cleanup (typos, etc) #142

merged 2 commits into from
Feb 28, 2021

Conversation

jprusik
Copy link
Contributor

@jprusik jprusik commented Feb 19, 2021 •
edited

What this PR does / why we need it:

  • Fixes some spelling and grammar typos (I left valid alternate spellings alone)
  • Also trims trailing whitespace, and adds/removes extra new lines where appropriate as flagged by markdownlint (I left mid-sentence line-breaks alone)

Which issue(s) this PR fixes:
N/A

@jprusik
fix some typos
d4b614f 
Signed-off-by: Jon Prusik <jprusik@classynemesis.com>
@jprusik
lint markdown spacing
af8304d 
Signed-off-by: Jon Prusik <jprusik@classynemesis.com>
@freephile freephile mentioned this pull request Feb 25, 2021
Closed
@jprusik jprusik changed the title Docs cleanup Docs cleanup (typos, etc) Feb 25, 2021
@EricHripko
Copy link
Collaborator

Also CC @kohidave

EricHripko
EricHripko approved these changes Feb 26, 2021
View reviewed changes
Copy link
Collaborator

@EricHripko EricHripko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome 🎉 Thank you for this contribution, looks really good ✅

@EricHripko EricHripko mentioned this pull request Feb 26, 2021
Closed
@ndeloof ndeloof merged commit f9a5c72 into compose-spec:master Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndeloof ndeloof ndeloof approved these changes

@EricHripko EricHripko EricHripko approved these changes

@hangyan hangyan Awaiting requested review from hangyan

@justincormack justincormack Awaiting requested review from justincormack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jprusik @EricHripko @ndeloof