-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional_contexts
to build
section
#307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me! Interested to hear thoughts from @tonistiigi @crazy-max @jedevc
eaa2f31
to
2fc44ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good ✅ Thank you for putting this together 🙌
120ac92
to
8d1678f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, maybe adding a hint when the constructor doesn't support additional contexts could be a great addition
8d1678f
to
fb467c4
Compare
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
fb467c4
to
139b322
Compare
What this PR does / why we need it:
Adds support for configuring additional/named contexts in the
build
section.Which issue(s) this PR fixes:
Fixes #306