Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional_contexts to build section #307

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

laurazard
Copy link
Member

@laurazard laurazard commented Feb 16, 2023

What this PR does / why we need it:

Adds support for configuring additional/named contexts in the build section.

Which issue(s) this PR fixes:

Fixes #306

Copy link
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me! Interested to hear thoughts from @tonistiigi @crazy-max @jedevc

build.md Outdated Show resolved Hide resolved
build.md Show resolved Hide resolved
build.md Outdated Show resolved Hide resolved
build.md Show resolved Hide resolved
build.md Show resolved Hide resolved
Copy link
Collaborator

@EricHripko EricHripko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good ✅ Thank you for putting this together 🙌

build.md Outdated Show resolved Hide resolved
@laurazard laurazard force-pushed the add-build-context branch 2 times, most recently from 120ac92 to 8d1678f Compare February 19, 2023 17:28
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, maybe adding a hint when the constructor doesn't support additional contexts could be a great addition

build.md Show resolved Hide resolved
build.md Show resolved Hide resolved
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for configuring additional build contexts
7 participants