New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make build.context
optional and default to .
#376
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This has been the behavior (unintentionally) of Compose v2.x all along, and nobody has complained about it...until we "fixed" it in v2.19, so I think this is a reasonable relaxing of strictness.
See also:
@ndeloof I may be wrong but it seems this change may have had some side-effects (not sure if intended) in the case where |
@danfundnel I don't think so services:
app:
extends:
file: ./abstract/base.yaml
service: base base.yaml services:
base:
build:
context: ./base
|
What this PR does / why we need it:
make
build.context
optional and default to.