Support condition: service_healthy #72
Conversation
Signed-off-by: Eric Hripko <ehripko@bloomberg.net>
There was a problem hiding this comment.
LGTM, but the description of depends_on should clarify both a simple "short notation" list and nested structures "long notation" are valid, so that it can introduce condition
This PR is missing update on the json schema. See https://github.com/docker/compose/blob/master/compose/config/config_schema_v2.4.json#L122-L141
Signed-off-by: Eric Hripko <ehripko@bloomberg.net>
|
@ndeloof I've addressed your feedback 🙂 |
|
Hey @ndeloof! Thank you for approving my PR - really appreciate it 🙌 Is there anything else I could do to get this landed? |
|
rebased and merged |
|
Thank you for merging this 🙌 😄 |
|
@ndeloof @EricHripko What happened here? The branch seems not merged and deleted but the commits are in the main branch. Did someone apply an external patch instead of merging the PR? |
|
Also, is this ever implemented in docker-compose? |
|
we don't use merge commits but rebase, so the commit to appear on master without an explicit merge commit |
Rebase merge changes PR status to "merged", not "closed". In the repo history there are multiple PRs whose latest status is "merged" but this one in particular shows as "closed", that's where I am lost. |
Yes, this has been supported by Docker Compose implementation since version 1.27.0 (although V2 potentially might have broken compatibility in places). |
|
@EricHripko Thank you. Is this documented in the changelog? I read it three times but couldn't see anything related to condition keys. |
|
It's under the first point - Merge 2.x and 3.x compose formats and align with COMPOSE_SPEC schema. There's a bunch of other V2 functionality that became mainstream again with the arrival of Compose spec, which is why |
What this PR does / why we need it:
This PR imports
condition: service_healthyfunctionality from Compose v2. The problem at hand was described and is being discussed in #68. Both the definition and the example were lifted from Compose v2 docs.Which issue(s) this PR fixes:
Fixes #68.