Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make version optional and define strict/standard/loose parsing mode #82

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Jun 5, 2020

What this PR does / why we need it:
This removes requirement for version and define parsing mode to manage unsupported or unknown properties. See discussion on #13 and community meeting notes

Which issue(s) this PR fixes:
Fixes #13

@ndeloof ndeloof force-pushed the version branch 2 times, most recently from 5f6d6aa to 6b21107 Compare June 5, 2020 06:33
@ndeloof ndeloof marked this pull request as ready for review June 5, 2020 06:33
Copy link
Contributor

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@EricHripko EricHripko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - really excited about this! ✅ Feel free to land once the minor typos inline are addressed 👍

spec.md Outdated Show resolved Hide resolved
spec.md Outdated Show resolved Hide resolved
spec.md Outdated Show resolved Hide resolved
close compose-spec#13

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't require version
4 participants