Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing external network #58

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

mprins
Copy link
Contributor

@mprins mprins commented Jun 3, 2024

  • Make admin network external in test case
  • Make the external attribute of a Network be an Optional boolean

resolves #57

@mprins mprins marked this pull request as ready for review June 3, 2024 08:47
@mprins
Copy link
Contributor Author

mprins commented Jul 4, 2024

@wst24365888 any chance of #57 being fixed and released with this PR

@kevinjone25
Copy link
Contributor

lgtm, the external attribute should be bool value at lagacy version
compose spec
FYI

@wst24365888
Copy link
Contributor

Hi @mprins ,

First of all, sorry for the late reply, I was in hospital for some time. I've reviewed your PR and it's great, thanks! I found out that our pipeline did not sync the latest compose_spec and convert it to corresponding compose_spec.py, so we'll merge your PR first and fix the sync issue soon.

Again, thanks for your contribution.

@wst24365888 wst24365888 merged commit 2c51d3e into compose-viz:main Jul 5, 2024
@mprins mprins deleted the issue#57_external_network branch July 5, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compose-viz fails to parse external network
3 participants