Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQS Scaling #194

Merged
merged 7 commits into from Oct 9, 2020
Merged

SQS Scaling #194

merged 7 commits into from Oct 9, 2020

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston added the enhancement New feature or request label Oct 7, 2020
@JohnPreston JohnPreston self-assigned this Oct 7, 2020
@JohnPreston JohnPreston linked an issue Oct 7, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #194 into root will decrease coverage by 0.02%.
The diff coverage is 88.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             root     #194      +/-   ##
==========================================
- Coverage   88.62%   88.60%   -0.03%     
==========================================
  Files          99      100       +1     
  Lines        4361     4441      +80     
==========================================
+ Hits         3865     3935      +70     
- Misses        496      506      +10     
Impacted Files Coverage Δ
ecs_composex/ecs/ecs_container_config.py 86.53% <ø> (-0.26%) ⬇️
ecs_composex/sqs/sqs_template.py 82.85% <ø> (ø)
ecs_composex/sqs/sqs_ecs.py 88.00% <84.61%> (-4.00%) ⬇️
ecs_composex/ecs/ecs_service_config.py 83.90% <88.23%> (+0.39%) ⬆️
ecs_composex/ecs/ecs_scaling.py 89.58% <89.58%> (ø)
ecs_composex/ecs/ecs_service.py 86.79% <100.00%> (+0.04%) ⬆️
ecs_composex/common/compose_resources.py 93.87% <0.00%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd60f86...44ada03. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 2 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnPreston JohnPreston changed the title WIP SQS Scaling SQS Scaling Oct 9, 2020
@JohnPreston JohnPreston merged commit 6ff203d into root Oct 9, 2020
@JohnPreston JohnPreston deleted the feature/sqs-step-scaling branch October 9, 2020 10:55
@JohnPreston JohnPreston linked an issue Oct 9, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AutoScaling Support Define SQS metrics alarms to scale in/out ECS services
1 participant