Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] elbv2 with empty DefaultActions crashes on target with Conditions #697

Merged
merged 2 commits into from
Nov 10, 2023
Merged

[BUG] elbv2 with empty DefaultActions crashes on target with Conditions #697

merged 2 commits into from
Nov 10, 2023

Conversation

thorfi
Copy link
Contributor

@thorfi thorfi commented Nov 9, 2023

Fixes #696

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnPreston
Copy link
Member

JohnPreston commented Nov 9, 2023 •
edited

Hi @thorfi
Thanks for this. I presume this then works for you when you do not set access and only set Conditions?
If that's the case, considering the tests failing are my own doing, happy to merge 👍

@JohnPreston JohnPreston merged commit 3eafa5e into compose-x:main Nov 10, 2023
4 of 5 checks passed
@thorfi
Copy link
Contributor Author

thorfi commented Nov 12, 2023

@JohnPreston hey, yes, exactly, it now works if I only set Conditions and don't set access. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnPreston JohnPreston JohnPreston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] elbv2 with empty DefaultActions crashes on target with Conditions
2 participants
@thorfi @JohnPreston