Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECS.ContainerDefinition.StopTimeout docker-compose.service.stop_grace_period #718

Merged
merged 5 commits into from
Nov 29, 2023
Merged

ECS.ContainerDefinition.StopTimeout docker-compose.service.stop_grace_period #718

merged 5 commits into from
Nov 29, 2023

Conversation

thorfi
Copy link
Contributor

@thorfi thorfi commented Nov 28, 2023

Set ECS.ContainerDefinition.StopTimeout from docker-compose.service.stop_grace_period

Fixes #717

@thorfi
Copy link
Contributor Author

thorfi commented Nov 28, 2023

Hi @JohnPreston ,

I tried to stick to naming/logging conventions as far as I understand them, but let me know if anything needs tweaking before you merge.

Thanks!

JohnPreston
JohnPreston reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@JohnPreston JohnPreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thorfi
Great stuff as always, thanks for the contribution.
See my notes below and let me know

ecs_composex/compose/compose_services/__init__.py Show resolved Hide resolved
ecs_composex/compose/compose_services/__init__.py Outdated Show resolved Hide resolved
@thorfi @JohnPreston
Update ecs_composex/compose/compose_services/__init__.py
1e0b7c3 
Co-authored-by: John Preston <1236150+JohnPreston@users.noreply.github.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnPreston
Copy link
Member

@thorfi can you please fix the indentation/formatting with black?
For future ease you your end, use pre-commit

python3 -m pip install pip -U; python -m pip install pre-commit
cd ecs_composex; pre-commit install

That way pre-commit will trigger when you do git commit and auto correct anything it can.

@JohnPreston JohnPreston merged commit f08fdaa into compose-x:main Nov 29, 2023
3 of 5 checks passed
@thorfi
Copy link
Contributor Author

thorfi commented Nov 29, 2023

@thorfi can you please fix the indentation/formatting with black? For future ease you your end, use pre-commit

Done! Thanks

@thorfi thorfi deleted the feature/717-ecs-containerdefinition-stoptimeout branch November 29, 2023 21:35
@JohnPreston JohnPreston mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnPreston JohnPreston JohnPreston left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] ECS.ContainerDefinition.StopTimeout docker-compose.service.stop_grace_period
2 participants
@thorfi @JohnPreston