Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix ecs_composex.ecs.ecs_family.ComposeFamily.task_ephemeral_storage #719 #720

Conversation

thorfi
Copy link
Contributor

@thorfi thorfi commented Nov 29, 2023

Fixes #719

Copy link

sonarcloud bot commented Nov 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@JohnPreston JohnPreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, neat!
Just need to format it with black please.
EDIT: I will do that via my PR

@JohnPreston JohnPreston merged commit 476bad5 into compose-x:main Nov 29, 2023
3 of 5 checks passed
@thorfi thorfi deleted the bugfix/719-service-deploy-labels-ecs.ephemeral.storage branch November 29, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] service.deploy.labels: ecs.ephemeral.storage not working
2 participants