This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
improve tests structure, convert rethinkdb writer to bulk #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
during the process of adding a mongodb -> rethinkdb integration test, it was found the performance of rethinkdb writes were awful so the writer was changed to do bulk inserts at a max of 1k docs, the tests structure changes included changing to ENV VARs for connection strings and using a non-encrypted config.yml file, unit tests were also parallelized due to the length of time it took for them to run on travisci
|
the other notable change is a switch to codecov to handle test coverage because it's able to handle reports being sent in groups which we needed in order to make the tests run in parallel. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during the process of adding a mongodb -> rethinkdb integration test, it was found the performance of rethinkdb writes were awful so the writer was changed to do bulk inserts at a max of 1k docs, the tests structure changes included changing to ENV VARs for connection strings and using a non-encrypted config.yml file, unit tests were also parallelized due to the length of time it took for them to run on Travis CI